Skip to content

Conversation

@p7nov
Copy link
Contributor

@p7nov p7nov commented Nov 28, 2024

@p7nov p7nov requested a review from sergepetrenko November 28, 2024 11:25
@sergepetrenko sergepetrenko self-assigned this Nov 29, 2024
@p7nov p7nov requested a review from Totktonada December 2, 2024 12:04
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of some parts that look in-progress everything seems correct. I left some non-blocking remarks, though.

Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks good to me.

@sergepetrenko sergepetrenko assigned p7nov and unassigned sergepetrenko Dec 3, 2024
@p7nov p7nov requested a review from lenkis December 4, 2024 07:59
* **Community Edition (CE)**

* Improvements around queries with offsets.
* Improvement in Raft implementation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Here and same term below) I see 2 ways of capitalization for Raft in the doc: Raft and RAFT.
https://www.tarantool.io/en/doc/latest/search/?q=raft
All caps seems more popular -- and "more correct" as for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the Raft website, Wikipedia, and some docs from software vendors, and haven't seen the all caps spelling. Sticking to the original (Raft website) is usually correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to ask our devs to update log messages then: they mostly say "RAFT".

p7nov and others added 2 commits December 4, 2024 15:49
@p7nov p7nov requested a review from lenkis December 4, 2024 08:49
@p7nov p7nov merged commit 344c233 into latest Dec 4, 2024
1 check passed
@p7nov p7nov deleted the gh-4653-whatsnew-3-3 branch December 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare What's new for Tarantool 3.3

5 participants